Working port to Qt5/KF5

Review Request #130244 - Created Sept. 7, 2017 and updated

Information
Malte Veerman
amarok
kf5
Reviewers
amarok

I apologize for the large code drop. I started working on this a few months back but was never quite satisfied with it until now.
This diff "finishes" the port to Qt5/KF5. No Kdelibs4support either. There are still lots of applets that need porting, the only services that work right now are Ampache and Magnatune and the whole scripting thing still needs a rewrite.
What also works is the new QML context area with the following applets: Currenttrack, Analyzer, Wikipedia and Songtext. Songtext only works because of a dirty hack I made in its backend script. Autotests are also fixed.
Apart from that I gave the whole plugin system an overhaul and ported the signal/slot connections to the new syntax. I also added a new class called "AmarokSharedPointer" that is basically identical to the old KSharedPointer. Porting that to QSharedPointer or QExplicitlySharedDataPointer seemed like a major headache. Also some minor fixes and improvements all over the place.

All autotests working.

Issues

  • 1
  • 2
  • 2
  • 5
Description From Last Updated
What's supposed to create this file or is it just missing from the diff? Installing errors out for me because ... Heiko Becker Heiko Becker
Anthony Fieroni
Malte Veerman
Anthony Fieroni
Andreas Sturmlechner
Andreas Sturmlechner
Heiko Becker
Mark Kretschmann
Malte Veerman
Review request changed

Change Summary:

First part now on phabricator: https://phabricator.kde.org/D8174
Updated this with some fixes for people who want to test the whole thing.
No more need for Qt5.9 and .desktop files should now be in order.

Diff:

Revision 7 (+15763 -25856)

Show changes

Loading...