Fixup for 'OFX import Online Statement Balance error'

Review Request #130233 - Created Aug. 21, 2017 and updated

Information
Ralf Habacker
kmymoney
323480
4756e56...
Reviewers
kmymoney

The background is that it was unclear what to use MyMoneyAccount::setValue("lastStatementDate") or MyMoneyAccount::setLastReconcilationDate()

Thomas suggests to use the latter, but there is a location in code using variant 1 which is fixed also with this commit.


  
Ralf Habacker
Ralf Habacker
Ralf Habacker
Review request changed

Description:

   

The background is that it was unclear what to use MyMoneyAccount::setValue("lastStatementDate") or MyMoneyAccount::setLastReconcilationDate()

   
~  

Thomas suggests to use the latter, but there is a location in code using code variant 1 which is fixed also with this commit.

  ~

Thomas suggests to use the latter, but there is a location in code using variant 1 which is fixed also with this commit.

Ralf Habacker

ping ?

Thomas Baumgart

   

I am not sure, if this is a good idea. Reconciliation means, that you have verified the data that your received from the bank and that it matches your records. Doing this automatically in the background somehow defeats the purpose unless checks have been performed that the online balance matches the one on file and that there are no additional transactions that have not been imported from the bank. Maybe, there are more checks required. Ah, and the transactions need to be marked reconciled also. Otherwise, this does not really make sense here.

Loading...