Print via QPrinter when rasterizing and printing annotations

Review Request #130218 - Created Aug. 4, 2017 and updated

Information
Oliver Sander
okular
master
Reviewers
okular

When the users chooses to print with rasterization and annotations, it is easy to print directly to a QPrinter, rather than converting to PostScript and then using CUPS tools. The code for it was already there, but it was hidden behind an #ifdef Q_OS_WIN. This patch enables it for all plattforms. If nothing else, it will make an interesting debugging tool, because it allows to bypass the postscript & cups toolchain from the GUI. This may allow to track down some of the numerous my-printer-settings-are-getting-ignored bugs.

Incidentally, this patch does fix at least one bug for me: Without it, my printer will happily ignore the 'print in grayscale' button. With the patch, that button is suddenly honoured.

This patch is a part of https://git.reviewboard.kde.org/r/130055/ . I post it here separately because I am not sure anymore whether the other stuff in that larger patch is a good idea.

Printed a few test sheets, to a printer and a file.

Issues

  • 1
  • 0
  • 0
  • 1
Description From Last Updated
Coding style issues: - there is a space after '(' but no space before ')' - the code after '{' ... Christoph Feck Christoph Feck
Albert Astals Cid
Oliver Sander
Albert Astals Cid
Oliver Sander
Oliver Sander
Review request changed

Status: Re-opened

Christoph Feck

   
generators/poppler/generator_pdf.cpp (Diff revision 2)
 
 
Coding style issues:
- there is a space after '(' but no space before ')'
- the code after '{' is not indented
  1. there is a space after '(' but no space before ')'

    I promise to fix that in a later commit

    the code after '{' is not indented

    That was intentional. Indenting it properly would have led to a patch with lots of whitespace changes. For easier reviewing I left the indentation as it was.

Loading...