completed port of highlight plugin

Review Request #130195 - Created July 21, 2017 and updated

Information
Vijay Krishnavanshi
kopete
Reviewers
mlaurent, pali

changed KDialog usage to QDialog and used qobject_cast


  

Issues

  • 2
  • 0
  • 0
  • 2
Description From Last Updated
Why QLatin1String and not QStringLiteral ? Laurent Montel Laurent Montel
buttonBox-> button(...), SLOT(setEnabled(bool))... and use new connect api Laurent Montel Laurent Montel
Laurent Montel

   

Why QLatin1String and not QStringLiteral ?

  1. I read in the example implementation. QStringLiteral will also do as they are only expecting string with a thin wrapper for comparison. I will change it.

buttonBox-> button(...), SLOT(setEnabled(bool))...

and use new connect api

  1. okay I will change it all the open review requests.

Laurent Montel

Did you test it if it works ?

  1. So is it work ?

Loading...