Add initial SQLite-based backend for the history plugin

Review Request #130166 - Created June 25, 2017 and updated

Information
Paulo Lieuthier
kopete
130164
Reviewers
kopete
mlaurent, pali

Having built a façade for the history plugin backends [1], this request proposes the long-awaited SQLite-based backend.

Pull from here: https://github.com/paulolieuthier/kopete/commits/protocols-categoric-logging

[1] https://git.reviewboard.kde.org/r/130164/

I only tested 1:1 conversations so far, using the Testbed protocol.

Issues

  • 4
  • 0
  • 0
  • 4
Description From Last Updated
Really singleton? This would break unloading plugin. Pali Rohár Pali Rohár
SQL injections Pali Rohár Pali Rohár
Why it is needed before storing message into SQLite database? Pali Rohár Pali Rohár
This code is full of SQL injections. Such thing is not acceptable. SQLite has prepared statments, so use them. Pali Rohár Pali Rohár
Pali Rohár
Paulo Lieuthier
Review request changed

Change Summary:

Added Github source.

Description:

   

Having built a façade for the history plugin backends [1], this request proposes the long-awaited SQLite-based backend.

   
  +

Pull from here: https://github.com/paulolieuthier/kopete/commits/protocols-categoric-logging

  +
   

[1] https://git.reviewboard.kde.org/r/130164/

Pali Rohár

   
This code is full of SQL injections. Such thing is not acceptable. SQLite has prepared statments, so use them.
It was needed for serialization via Qt4XML.
Loading...