Initial work on creating a backend façade for history and isolating XML-related code as a specific implementation

Review Request #130164 - Created June 20, 2017 and updated

Information
Paulo Lieuthier
kopete
130166
Reviewers
kopete
mlaurent, pali

This is done on top of [1], I don't know how to upload a diff only for this current branch.

This patch sets the initial work to separate the history plugin interface from its actual storage implementation details. I think isolating the XML backend is a good idea, because it may continue to be used and it'll be easier to test the new backend, comparing to the XML one.

There are much more to do here, I will update the diff soon.

Pull from here: https://github.com/paulolieuthier/kopete/commits/initial-facade

[1] https://git.reviewboard.kde.org/r/130154/


  

Issues

  • 2
  • 0
  • 0
  • 2
Description From Last Updated
merge problem? Pali Rohár Pali Rohár
Wrong design. You do not need new instance of backend for every contact. Pali Rohár Pali Rohár
Pali Rohár

   
plugins/history/CMakeLists.txt (Diff revision 2)
 
 
merge problem?
Wrong design. You do not need new instance of backend for every contact.
Pali Rohár
Basically I do not think we need to have XML storage in new KF5 Kopete. New storage (SQLite) should be enough. One storage would mean less (really less!) technical code around. What would be neeed is to convert old XML based history to new storage.
Loading...