Replace KDebug by Qt's categorical logging in Kopete's protocols

Review Request #130161 - Created June 18, 2017 and updated

Information
Paulo Lieuthier
kopete
Reviewers
kopete
mlaurent, pali

This was done mostly using regex, and now KDebug is no longer needed to link the protocols.

Pull from here: https://github.com/paulolieuthier/kopete/commits/protocols-categoric-logging

Testbed account and test user creation and simple conversation. Only logging was changed.

Issues

  • 7
  • 4
  • 0
  • 11
Description From Last Updated
it's not debug categories changes no ?:) Laurent Montel Laurent Montel
same here etc. Laurent Montel Laurent Montel
same here etc. Laurent Montel Laurent Montel
same here Laurent Montel Laurent Montel
same here Laurent Montel Laurent Montel
you removed all debug ? Laurent Montel Laurent Montel
Why removed all debug ? Laurent Montel Laurent Montel
Paulo Lieuthier
Laurent Montel
Laurent Montel
Ship It!
Luigi Toscano
Sorry for the delay, but it should be changed. For example there are multiple declaration of ecm_qt_declare_logging_category for the same header file; but it's not needed, you can just define it once, defining the "sources" in a separate cmake variable and reusing it multiple times.

Please note that you can use a script to do this change globally (even if it requires some changes in this case, when you use the same category in multiple  sections of the code):
https://cgit.kde.org/kde-dev-scripts.git/tree/kf5/convert-qkdebug-to-qcdebug.sh

I'm going to detach the commit containing " Fix build failure in Gadu protocol " and commit it, as it is needed independently from the main change (and separate changs should be committed separately; yes, they are separated on github, but the place for the review is here on kde.org)

Can you please rebase this on the current kf5 branch? Also please note that reviewboard is closed for new reviews and will shut down in few days, https://phabricator.kde.org is the way to go (see https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist ).
Loading...