Bug 321575 - Change window title when searching

Review Request #130157 - Created June 13, 2017 and updated

Information
XY Quadrat
dolphin
321575
Reviewers
dolphin, usability
elvisangelaccio, emmanuelp

When you search for a file (e.g. "hello world") the window title of Dolphin will change to "Searching hello world". This commit includes creating a helper function currentSearchText() in dolphinviewcontainer.cpp which then gets called from dolphinmainwindow.cpp.

This fixes BUG: 321575

  • Disables it iself after search bar is hidden
  • Works with multiple word searches

Issues

  • 0
  • 4
  • 0
  • 4
Description From Last Updated
Anthony Fieroni
Christoph Feck
XY Quadrat
XY Quadrat
Elvis Angelaccio
XY Quadrat
XY Quadrat
Elvis Angelaccio
Elvis Angelaccio
XY Quadrat
Review request changed

Description:

~  

When you search for a file (e.g. "hello world") the window title of Dolphin will change to "Searching hello world". This commit includes moving the DolphinSearchBox object created in dolphinviewcontainer.h from private to public, so that dolphinmainwindow.cpp can access the input the user typed in.

  ~

When you search for a file (e.g. "hello world") the window title of Dolphin will change to "Searching hello world". This commit includes creating a helper function currentSearchText() in dolphinviewcontainer.cpp which then gets called from dolphinmainwindow.cpp.

  +
  +

This fixes BUG: 321575

Groups:

+usability
XY Quadrat

I just noticed that this problem (that the window title is not really descriptive or not translated) is also occurring with e.g. the trash (the window title is simply "trash - / -- Dolphin" and is not translated). So maybe a deeper change is required if we do not want to add an extra case for every situation.

  1. See https://bugs.kde.org/show_bug.cgi?id=211959

Loading...