Bug 321575 - Change window title when searching

Review Request #130157 - Created June 13, 2017 and updated

Information
XY Quadrat
dolphin
321575
Reviewers
dolphin
elvisangelaccio, emmanuelp

When you search for a file (e.g. "hello world") the window title of Dolphin will change to "Searching hello world". This commit includes moving the DolphinSearchBox object created in dolphinviewcontainer.h from private to public, so that dolphinmainwindow.cpp can access the input the user typed in.

  • Disables it iself after search bar is hidden
  • Works with multiple word searches

Issues

  • 0
  • 4
  • 0
  • 4
Description From Last Updated
Anthony Fieroni
Christoph Feck
XY Quadrat
XY Quadrat
Elvis Angelaccio
XY Quadrat
XY Quadrat
Review request changed
Elvis Angelaccio

Please update the commit message, it's no longer true that "... moving the DolphinSearchBox object created in dolphinviewcontainer.h from private to public".

Also, add "BUG: 321575" so that the bug report will be automatically closed after pushing the commit.

Elvis Angelaccio

One more thing that I just noticed: this patch doesn't change the tab titles, they still show "baloosearch". I wonder if we should just show a generic string "Searching..." that we could use also for tabs. Input from the VDG would be nice (you can add the 'usability' group as reviewers).

Loading...