Bug 262265 chmlib should not send qFatal if encoding could not be guessed

Review Request #130106 - Created April 26, 2017 and submitted

Information
Gilbert Assaf
okular
262265
619ec9b...
Reviewers
okular

Okular sends a 'qFatal()', if no encoding could be guessed. This will also create a core dump crashing Okular and all open document in this instance.


  
Albert Astals Cid
Gilbert Assaf
Review request changed

Status: Closed (submitted)

Luigi Toscano

Please check https://community.kde.org/Policies/Commit_Policy#Special_keywords_in_GIT_and_SVN_log_messages for next reviews (in this case, BUG: and REVIEW: keyword were missing).

(also, this could have gone to the Applications/17.04 branch instead - Albert?)

  1. sorry I saw this message to late. I was assuming just using rbt patch would be enough. I will definitly do this next time!

Loading...