Added autotest directory and moved Oscar Protocol autotests

Reviews
Diff

- Download Diff

Information
Submitter:	Vijay Krishnavanshi
Repository:	kopete
Branch:
Bugs:
Depends On:
Reviewers
Groups:
People:	mlaurent, pali

Description

Work done in this commit :
- Removed the unused autotests from lib kopete directory
- Moved Oscar Protocol autotests to autotests directory
- Added autotest directory structure

Testing Done

Issues

0
11
0
All Issues: 11

Description	From	Last Updated
nope we use BUILD_TESTING in kf5 => we can activate it when building with kdesrcbuild. and you need to remove ...	Laurent Montel	April 27, 2017, 9:43 p.m.
why you removed it ?	Laurent Montel	May 18, 2017, 1:51 a.m.
Did you test with 5.2.0 ? Do you have 5.2.0 installed ?	Laurent Montel	May 18, 2017, 1:52 a.m.
Why not required ?	Laurent Montel	May 18, 2017, 1:52 a.m.
Why ?	Laurent Montel	May 18, 2017, 1:51 a.m.
I don't understand it.	Laurent Montel	May 18, 2017, 1:51 a.m.
why duplicate it ?	Laurent Montel	May 18, 2017, 1:51 a.m.
indent.	Laurent Montel	May 18, 2017, 1:51 a.m.
Are you sure that kdesrcdir is still defined ? it was defined in kde4 not kf5	Laurent Montel	May 18, 2017, 1:51 a.m.
missing copyright	Laurent Montel	May 19, 2017, 2:32 a.m.
Each file need to have a copyright see code :)	Laurent Montel	May 19, 2017, 2:32 a.m.

CMakeLists.txt (Diff revision 1)

Show all issues

nope we use BUILD_TESTING in kf5

=> we can activate it when building with kdesrcbuild.
and you need to remove option(WITH_TESTS...)

Vijay Krishnavanshi April 26, 2017, 8:10 a.m.

Ah I found out this BUILD_TESTING option is automatically created in Ctest.
I will submit the revised diff.

Change Summary:

Updated Diff Fixed issue of options

Diff:

Revision 2 (+623 -3069)

Show changes

	CMakeLists.txt
	libkopete/CMakeLists.txt
	libkopete/tests/CMakeLists.txt
	libkopete/tests/README
	libkopete/tests/avatarselectortest_program.h
	libkopete/tests/avatarselectortest_program.cpp
	libkopete/tests/create_test.rb
	libkopete/tests/kopetecontactlist_test.h
	83 more

tests/libkopete/CMakeLists.txt (Diff revisions 1 - 2)

Show all issues

why you removed it ?

Vijay Krishnavanshi April 29, 2017, 2:59 a.m.

I had mistakenly included it in previous diff.
I was trying to reuse the tests of libkopete also. But as structure of libkopete has changed so tests from scratch need to be written. I plan to first write tests for the plugins.

CMakeLists.txt (Diff revision 2)

Show all issues

Did you test with 5.2.0 ?
Do you have 5.2.0 installed ?

Vijay Krishnavanshi May 1, 2017, 5:10 p.m.

I had tested it with 5.2.0 as I was not able to find 5.4.0 version even in the development module. Do you have 5.4.0 version installed?

Laurent Montel May 2, 2017, 5:16 a.m.
```
Yep even 5.5.0 or 5.5.40 :)
```

CMakeLists.txt (Diff revision 2)

Show all issues

Why not required ?

CMakeLists.txt (Diff revision 2)

Show all issues

Why ?

CMakeLists.txt (Diff revision 2)

Show all issues

I don't understand it.

Vijay Krishnavanshi May 1, 2017, 5:10 p.m.

This was to enable make check command to run tests.
I read it here https://cmake.org/Wiki/CMakeEmulateMakeCheck

Laurent Montel May 2, 2017, 5:16 a.m.

So it's a problem on your install as we don't redefined it in kde package.
It's automatique.
"make test" doesn't work for you ?

Vijay Krishnavanshi May 18, 2017, 1:51 a.m.
```
Its working, removed in the newer diff
```

tests/kopete/CMakeLists.txt (Diff revision 2)

Show all issues

why duplicate it ?

tests/protocols/oscar/buffertest.cpp (Diff revision 2)

Show all issues

indent.

tests/protocols/oscar/oscartestbase.h (Diff revision 2)

Show all issues

Are you sure that kdesrcdir is still defined ?
it was defined in kde4 not kf5

Vijay Krishnavanshi May 1, 2017, 5:10 p.m.

This was defined by adding definitions in CMakeLists.txt of the oscar protocol tests. In file tests/protocols/oscar/CMakeLists.txt

Laurent Montel May 2, 2017, 5:16 a.m.
```
Ok I see.
```

Change Summary:

Fixed issues and updated description

Description:

		Work done in this commit :
		- Removed the unused autotests from lib kopete directory
		- Moved Oscar Protocol autotests to autotests directory
~		- Added autotest directory structure
	~	- Added autotest directory structure
-		- Required LIBKLEO_LIB_VERSION set to 5.2.0
-		- Added make check custom target (autotests can be run using "make check" command)

Diff:

Revision 3 (+613 -3067)

Show changes

	CMakeLists.txt
	libkopete/CMakeLists.txt
	libkopete/tests/CMakeLists.txt
	libkopete/tests/README
	libkopete/tests/avatarselectortest_program.h
	libkopete/tests/avatarselectortest_program.cpp
	libkopete/tests/create_test.rb
	libkopete/tests/kopetecontactlist_test.h
	83 more

tests/protocols/oscar/buffertest.cpp (Diff revision 3)

Show all issues

missing copyright

Vijay Krishnavanshi May 18, 2017, 7:57 a.m.

It has GNU Free Documentation License version 1.3
Should I include that or something else needs to be done?

tests/protocols/oscar/buffertest.cpp (Diff revision 3)

Show all issues

Each file need to have a copyright see code :)

Diff:

Revision 4 (+628 -3067)

Show changes

	CMakeLists.txt
	libkopete/CMakeLists.txt
	libkopete/tests/CMakeLists.txt
	libkopete/tests/README
	libkopete/tests/avatarselectortest_program.h
	libkopete/tests/avatarselectortest_program.cpp
	libkopete/tests/create_test.rb
	libkopete/tests/kopetecontactlist_test.h
	83 more

Ship it!

seems ok now.

Vijay Krishnavanshi May 19, 2017, 8:49 a.m.

No I know why it is advised to keep commits short :P

Vijay Krishnavanshi May 19, 2017, 8:50 a.m.
```
*now
```

Laurent Montel May 25, 2017, 7:32 a.m.

I can't see commit ?
did you already commit ?

Vijay Krishnavanshi May 25, 2017, 8:16 a.m.

I am facing an issue with kde identity. I will commit as soon as it is resolved.
Also I am writing tests for the plugins did you see the report :)

You have a pending review.

Review Board 2.5.15

Screenshots

Files

Issues

Change Summary:

Diff:

Change Summary:

Description:

Diff:

Diff:

Status: Closed (submitted)