Added autotest directory and moved Oscar Protocol autotests
Review Request #130097 - Created April 21, 2017 and submitted
Information | |
---|---|
Vijay Krishnavanshi | |
kopete | |
Reviewers | |
mlaurent, pali |
Work done in this commit :
- Removed the unused autotests from lib kopete directory
- Moved Oscar Protocol autotests to autotests directory
- Added autotest directory structure
-
CMakeLists.txt (Diff revision 1) -
nope we use BUILD_TESTING in kf5
=> we can activate it when building with kdesrcbuild.and you need to remove option(WITH_TESTS...)
-
tests/libkopete/CMakeLists.txt (Diff revisions 1 - 2) -
why you removed it ?
-
CMakeLists.txt (Diff revision 2) -
Did you test with 5.2.0 ?
Do you have 5.2.0 installed ? -
CMakeLists.txt (Diff revision 2) -
Why not required ?
-
CMakeLists.txt (Diff revision 2) -
Why ?
-
CMakeLists.txt (Diff revision 2) -
I don't understand it.
-
tests/kopete/CMakeLists.txt (Diff revision 2) -
why duplicate it ?
-
tests/protocols/oscar/buffertest.cpp (Diff revision 2) -
indent.
-
tests/protocols/oscar/oscartestbase.h (Diff revision 2) -
Are you sure that kdesrcdir is still defined ?
it was defined in kde4 not kf5
Change Summary:
Fixed issues and updated description
Description: |
|
|||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+613 -3067) |
-
tests/protocols/oscar/buffertest.cpp (Diff revision 3) -
missing copyright
-
tests/protocols/oscar/buffertest.cpp (Diff revision 3) -
Each file need to have a copyright see code :)
seems ok now.