[Ksirk frameworks] Removal of KDELibs4Support
Review Request #130095 - Created April 21, 2017 and discarded
[Ksirk frameworks] Remove KDELibs4Support
- Didn't test Jabber funcionality, although some changes were made there.
- Game play works.
- KDE New Stuff doesn't work neither in frameworks nor master. Has to be fixed.
|It's better to use qCDebug(...) so we can disable debug. See kdepim apps or others which use it.||Laurent Montel|
Could you please split this into
- a review which ports away from kDebug (and possibly to categorized logging, there is a macro in kde-dev-scripts/kf5/convert-qkdebug-to-qcdebug.sh which does most of the work and suggests the missing manual steps, it should be trivial);
- a review for everything else (unless some other change is big enough to require a further split)
Is this needed in KF5 at all?
Is this the right way to port KSocketFactory?
Just comment out assigned but not used variables.
It might be the case there is a bug in calculating positions, so I'm keeping the code for the refference.
Not sure if this is right?
Is this OK?
Didn't try this.
Is this a proper way to port?