Review Request #130094 - Created April 21, 2017 and discarded
Implement QPlatformTheme::fileIconPixmap() to make QFileIconProvider work.
|no need for "virtual" since we have Q_DECL_OVERRIDE||Kai Uwe Broulik|
Thanks for your patch!
Plasma reviews are nowadays handled on https://phabricator.kde.org/ - could you perhaps upload it there again? I just don't want it to get lost here :/
Also, I'm not sure about having a separate FileIconProvider class. You also seem to reimplement quite a lot of logic. Can you perhaps try KIO::iconNameForUrl (in KIOCore I think) which has all of that mimetype resolution and special folders logic already built-in, potentially allowing you to reduce your patch to like 10 lines of code :)
(Btw using Qt 5.7 features is fine, Plasma-integration is released alongside Plasma, not KDE Frameworks, and the upcoming Plasma 5.10 release will depend on Qt 5.7 anyway)