Make kwalletd5 service both org.kde.kwalletd5 and org.kde.kwalletd

Review Request #130058 - Created March 29, 2017 and updated

Andreas Sturmlechner

These are not my own patches, I'm creating this review request after having been made aware of kwalletd4_dbus_compat branch in kwallet.git, which I simply rebased on top of current master (author of course preserved) to be able to test it. I think it would be a great improvement over the current situation that is rather confusing to the users.

The changes are organised in 5 commits:

  • Check for unique applicaton instance as early as possible
    Exit before KWalletD and the MigrationAgent has been initialized.
    The return value is changed, but concurrent instatiation of kwalletd is
    not a fault.

  • Only start timer for migration agent if necessary

  • Whitespace fixup
  • Signal completion of migration agent
  • Replace kwalletd4 after migration has finished
    kwalletd5 can service both org.kde.kwalletd5 and org.kde.kwalletd

Migration itself was not tested so far, but a legacy application like ksirk was able to create a new wallet just fine and can access it as well. I do not have kwalletd4 installed anymore.

David Faure

Makes sense to me, +1.

  1. Thanks, anyone else who wants to +1?

    I've tried to test migration today but it didn't work. May as well have nothing to do with te patch and be caused by the permanently troubled migration agent though... KMail happily gets its IMAP password from kwallet5 though after manually export/import via XML files.

  2. As suspected, on my test system migration is broken regardless of with these patches or not.

  3. Are you planning on looking into that? ;-)

    These patches are related to migration, it feels a bit wrong to commit changes around migration and still leave it broken.

  4. I don't feel like I'm up to that task. Also, the reason for why it works for some, but not all the systems, has afaik never been established.