Bug 288042 - Option to reset forms

Review Request #130057 - Created March 29, 2017 and updated

Information
Gilbert Assaf
okular
288042
a4ca2c3...
Reviewers
okular

Clear Contents of FormLineEdit, TextAreaEdit and FileEdit + unchecks CheckBoxEdit and ListEdit form elements.

I don't touch RadioBoxes and ComboBoxes, because I am not sure, to which state I should reset/clear them. Especially for ComboBox, I am not sure if clearing them could be harmful.


  

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
Oliver Sander
Gilbert Assaf
Albert Astals Cid
Gilbert Assaf
Albert Astals Cid
Gilbert Assaf
Review request changed

Change Summary:

Form reset doesn't switch focus anymore if ListEdits are involved. And the option is only visible in edit mode.

Commit:

-f829f039b8cec6c5b639aa13d356bbe59aefa395
+a4ca2c3db6c650851390812ce6c9c13342558ea9

Diff:

Revision 4 (+65 -4)

Show changes

Albert Astals Cid

Do you think you could do an autotest using formSamples.pdf ?

  1. I don't know how to put text into a PageViewItem from an autotest class. I can't access the necessary members, because of the way PageViewPrivate is declared. Even with friending classes I could not get it to work.
    I think the only way to create an autotest is to reimplement this functionality using Okular::FormField.

  2. There's tests that already do that, get inspired by them.

Loading...