libktorrent: HTTP Proxy is ignored

Review Request #130037 - Created March 20, 2017 and submitted

Information
Alexander Trufanov
libktorrent
master
377822
Reviewers
ktorrent
aacid, shaforo

In KTorrent 5.0 the HTTP Proxy setting is ignored due to problem in libktorrent's HTTPTracker::doAnnounce() in case of KIO transport.
I have privoxy on top of tor, both on my local machine, and I don't see any traffic to my proxy in its log. Also https://torguard.net/checkmytorrentipaddress.php displays my real ip.

It seems the problem is that you must set up "ProxyUrls" metadata and current implementation fills in only "UseProxy". Looks like KIO ignores proxy setting in this case. Perhaps it's a KIO problem. Didn't dig deeper.

After setting "ProxyUrls" equal to "UseProxy" avarything seems to get working as expected.

UPD.: I tend to think that "UseProxy" is ignored if no "ProxyUrls" is set or overwrited with "ProxyUrls" even if "ProxyUrls" is empty. If i'm looking at right code line... At least it works if I comment out md["UseProxy"] = p; and leave only "ProxyUrls".

UPD3: Another KIO problem that was referenced here was solved under https://git.reviewboard.kde.org/r/130040/


  

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
Alexander Trufanov
Alexander Trufanov
Alexander Trufanov
Anthony Fieroni
Alexander Trufanov
Alexander Trufanov
Alexander Trufanov
Albert Astals Cid
Alexander Trufanov
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted with commit 4049602f8db96cc1c48fb07ce799139fd62b1d57 by Alexander Trufanov to branch master.
Loading...