Add a dedicated 'Copy To Stash' context menu button for the upcoming stash:/ ioslave

Review Request #130028 - Created March 18, 2017 and updated

Information
arnav dhamija
dolphin
Reviewers
dolphin
bgupta, dfaure, emmanuelp

This patch adds a dedicated Copy to Stash button in Dolphin's context menu when items are selected in a group. Triggering this action adds the selected items to the clipboard and pastes it on the stash:/ ioslave.

I have encountered some problems when writing this patch. For one, though the QAction appears in the context menu as expected, it does not show up in the Menubar's File Menu though it is added under that in the dolphinui.rc file. Apart from this, the patch works fine in manual testing.


  

Files


Issues

  • 2
  • 0
  • 0
  • 2
Description From Last Updated
i18n() Boudhayan Gupta Boudhayan Gupta
i18n() Boudhayan Gupta Boudhayan Gupta
arnav dhamija
arnav dhamija
Boudhayan Gupta
arnav dhamija
arnav dhamija
Boudhayan Gupta

LGTM. Fix the two things below, then ship it!

  1. Quote: "I have encountered some problems when writing this patch. For one, though the QAction appears in the context menu as expected, it does not show up in the Menubar's File Menu though it is added under that in the dolphinui.rc file."

    That isn't fixed yet.

    Also, since this adds a menu entry (ok.. for now only in the right mouse button), i'd prefer to wait for Emmanuel' opinion and vote of approval since he is the maintainer of Dolphin. He might have something to say about where to place the button in the RMB or what it's most ideal name would be.

src/dolphinmainwindow.cpp (Diff revision 4)
 
 

i18n()

src/dolphinmainwindow.cpp (Diff revision 4)
 
 

i18n()

Loading...