Dolphin: Display message in terminal panel if Konsole is not installed

Review Request #130007 - Created March 12, 2017 and updated

Information
Don Nguyen
dolphin
371822
Reviewers
dolphin
This patch will show a QLabel with the text "KonsolePart not found.  Install Konsole and restart Dolphin to enable this feature." in place of where the terminal widget would be if Konsole is not installed.
Manual testing, see screenshot.

Files


Issues

  • 2
  • 0
  • 0
  • 2
Description From Last Updated
Please wrap the message in an i18n() call. Elvis Angelaccio Elvis Angelaccio
TerminalPanel already has a layout (m_layout), so this is wrong and causes a runtime warning. Either just use m_layout or ... Elvis Angelaccio Elvis Angelaccio
Elvis Angelaccio
Don Nguyen
Review request changed

Change Summary:

Using KMessageWidget

Diff:

Revision 2 (+14 -2)

Show changes

Added Files:

Elvis Angelaccio

Sorry this took so long. You may want to re-upload to patch on Phabricator, since Reviewboard will be closed soon.

src/panels/terminal/terminalpanel.cpp (Diff revision 2)
 
 

Please wrap the message in an i18n() call.

src/panels/terminal/terminalpanel.cpp (Diff revision 2)
 
 

TerminalPanel already has a layout (m_layout), so this is wrong and causes a runtime warning.

Either just use m_layout or make hbox a child of m_layout.

Loading...