[kdeconnect-android] Add swipe to refresh to device pairing activity
Review Request #129980 - Created March 2, 2017 and submitted
Add swipe to refresh to device pairing activity
This makes it more conform to material design standard
Built and tested thoroughly on an Android 7.1.1 (API Level 25) device
A very similar view to this one is used when you select a device after using the "Share" functionality in Android (see src/org/kde/kdeconnect/Plugins/SharePlugin/ShareActivity.java). Maybe you can change it there as well?
The two xmlns: and tools: lines should be in the topmost element.
Don't add whitespaces.
menuProgress is now unused, remove it from here and from the menu XML.
Is this call to updateComputerList really needed? I think it will be called eventually as a callback anyway... Can you see if it still works after removing it?
Add swipe to refresh action to share plugin as well.
I don't know why there are two
onCreate, I suspect if this is a kind of workaround for something, but this will break swipe to refresh mechanism, so I removed one of them, and the app still works fine.
Some changes explained:
Refreshbutton to inner menu?
This is because as explained in comments before, some users may have difficulties performing swipe action, so we'll put that alterative to a menu item
and why put it in an inner menu is that user may think the effect of such menu item may differ from the swipe to refresh action, so to better prevent that
misunderstanding, I put this item into a inner menu item.
Revision 4 (+100 -78)