Use GNUInstallDirs instead of custom variables

Review Request #129974 - Created Feb. 28, 2017 and updated

Information
Andreas Sturmlechner
heaptrack
1393936...
Reviewers
mwolff
Use standardised directories and at the same time give distributions
leverage to override for e.g. multiarch libdir.

heaptrack_interpret: Changes install path
  from ${LIB_INSTALL_DIR}/heaptrack/libexec
  to ${CMAKE_INSTALL_LIBEXECDIR}

Also, less lines.

  

Issues

  • 1
  • 0
  • 0
  • 1
Description From Last Updated
This and the other related changes to the _OUTPUT_DIRECTORY break an essential feature for me - being able to compile ... Milian Wolff Milian Wolff
Milian Wolff

   
  1. So, will you fix this? Is there anything I could help you with?

  2. Thanks for checking back; I will try to fix these points as time allows, but right now I am occupied with other tasks.

  3. Please also look at the existing LIB_SUFFIX and whether it solves your issues

src/analyze/gui/CMakeLists.txt (Diff revision 1)
 
 

This and the other related changes to the _OUTPUT_DIRECTORY break an essential feature for me - being able to compile heaptrack and running it from the build folder without installing it.

Note how you set the absolute install dir as the output dir, so essentially building will already install heaptrack - which is not good at all. Compiling it as a user and installing it as root to /usr/local won't work anymore.

If you find a way to fix this, then I'm all for this patch. But, as it stands, I'm very much against it. If you want to get arch specific lib dirs, simply set LIB_SUFFIX, that works and was added for this specific purpose.

Loading...