Added notification feature to the kde now

Review Request #129937 - Created Feb. 10, 2017 and updated

Information
Vijay Krishnavanshi
kde-now
Reviewers
adityadevsharma

Added the feature using knotification and used datahandler to create the object. Did not test it in working situation.

No

Issues

  • 3
  • 0
  • 0
  • 3
Description From Last Updated
Add a space between comma, like (QString name, QString message) Also, are you sure it doesn't need to be a ... Aditya Dev Sharma Aditya Dev Sharma
Consider changing arguments to references (&) unless a copy is really needed Aditya Dev Sharma Aditya Dev Sharma
Add a space b/w QObject* and parent Similarly, add spacing before and after : Aditya Dev Sharma Aditya Dev Sharma
Aditya Dev Sharma

Make minor coding style improvements, like spacing before and after "="(like = this) and not (like=this) . Also make arguments to functions start with a small letter.
Also, build and test the code. And submit another review

src/calendarnotification.h (Diff revision 1)
 
 

Add a space between comma, like (QString name, QString message)
Also, are you sure it doesn't need to be a reference (&)

src/calendarnotification.h (Diff revision 1)
 
 

Consider changing arguments to references (&) unless a copy is really needed

src/calendarnotification.cpp (Diff revision 1)
 
 

Add a space b/w QObject* and parent
Similarly, add spacing before and after :

Loading...