fix some bugs in kcm_colors

Review Request #129902 - Created Jan. 29, 2017 and submitted

Information
Martin Koller
plasma-desktop
master
372309, 372407
Reviewers
plasma
mart, ochurlaud

the new kcm_colors has some bugs which this patch addresses:

1) memory leak when opening SchemeEditorDialog (is never deleted)
2) The color preview widget can be reduced in height to nearly zero, which makes no sense
3) The scheme editor does not reflect any color change in the preview widget
4) triple-redundant widgets in the scmeditorcolors.ui file
5) user unfriendly current tab when opening the SchemeEditorDialog (I want to change a color, so the color tab shall be active)
6) Unneeded and incorrect tab index enum (enum values were not corresponding to the index the tab was inserted)
7) The SchemeEditorDialog did not just only expand the color table when enlarging the dialogs height


  
Olivier Churlaud
Martin Koller
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted with commit 1d05792ad782ce4cd41e31c1ab6eef3026b5218b by Martin Koller to branch master.
Loading...