Do nothing in ShowMenubarActionFilter::updateAction if there are no menubars
Review Request #129892 - Created Jan. 26, 2017 and submitted
|Albert Astals Cid|
It makes no sense to treat no menubars as all menubars native so just bail early, the app is probably still in construction if there's no menubars but it actually has a showmenubaraction.
Dolphin behaves better regarding the show menubar action.
So, wait a minute i just quote you
This patch attempts to fix it by iterating all the main windows when they are shown and if all the menubars of all mainwindows are native, then hides the show menu bar action (basically erasing it from existence). from https://git.reviewboard.kde.org/r/129261/
This has nothing to do with whether you are using Unity or Plasma from https://git.reviewboard.kde.org/r/129885/
I want an explanation, i never use Unity, i will never use it, but i want know in Unity - Kate, Dolphin etc. on showEvent allMenuBarsNative == true, wasNative == true ?
If so, i'm -1 for this approach