[lookandfeel] Support changing window decoration
Review Request #129872 - Created Jan. 22, 2017 and updated
|129867, 129869, 129868|
|broulik, hpereiradacosta, mart|
Applying a look and feel global theme will change visual changes in:
1. Widget style
2. Color scheme
4. Plasma theme
5. Mouse pointer
6. Window switcher
7. Desktop switcher
8. Window decoration
This patch aims to implement (or correct) applying of windows decortion. When user select Oxygen look and feel (before was other no matter what) it should read default configuration for oxygen look and feel. It's located in oxygen/lookandfeel/contents/defaults (https://git.reviewboard.kde.org/r/129867/), e.g. it's look like
In KCMLookandFeel::load() we get what package support (you see oxygen does not support changing WindowSwitcher and DesktopSwitcher)
In KCMLookandFeel::save() we read what is supported now in value e.g. library=org.kde.oxygen and write it in place that will work and kwin expects in kwinrc by function
KCMLookandFeel::setWindowDecoration kwinrc does not have a theme -> i will remove it. In DBUS calls, after writing in right place of configuration, we apply all changes.
|this is not reading the default settings. Also theme is missing||Martin Flöser|
|what about theme?||Martin Flöser|
|I don't understand why the group is changed here? Was if wrong before? How was it wrong?||Martin Flöser|
|If this is no longer needed, why put it together with an unrelated change?||Martin Flöser|
|what is this method for? Your change has no call to it||Martin Flöser|
|what is this method for, your change nowhere calls it?||Martin Flöser|
I'm sorry, but this looks rather badly rebased. You deleted code, you shuffled code around, you broke things by reading from the wrong group.
I do not understand the change and reading the review it looks like Marco does neither. Please clean up to what you actually want to change and please add a description which explains what it does and not something based on an older idea.
I would have a much better time understanding your change if you would update the description and an explanation. Currently it says "Support changing window decoration" which your change does not do. And you have no explanation at all. I'm trying to understand your change, but I cannot. I do not understand any of the changes you do. Please explain, so that others can understand it and determine whether it's correct or not. Currently my assumption is, that it's not correct, because there are changes looking wrong to me, like introduction of methods which are not called, removal of code to reconfigure KWin, etc. etc.