KFileMetaData: add a new property DiscNumber for audio files from multi-disc albums

Review Request #129839 - Created Jan. 15, 2017 and submitted

Information
Matthieu Gallien
kfilemetadata
129798
759fd0c...
Reviewers
baloo

the new property is appended at the end of the existing enums such that
binary compatibility is kept. The special values at the end of the enums
are currently only used by automatic tests of KFileMetaData. There
should be no harm by this commit.

At time of this commit, lxr.kde.org shows no user of the special values
at the end of the enum. My patch should not cause any problems.

One interesting question is how to manage caching of new properties in
Baloo when one modify KFileMetaData. I currently have no idea.

There should be more patches to add new properties after this review if needed (some music related properties are still missing).

Automatic tests are still all OK on my setup.

I have modified my music player to makes use of it and it works.

I have not yet any clear idea how to makes Baloo reindex the files to cache new properties.

Issues

  • 0
  • 2
  • 0
  • 2
Description From Last Updated
Matthieu Gallien
David Faure
Matthieu Gallien
David Faure
Matthieu Gallien
Matthieu Gallien
David Faure
Matthieu Gallien
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted with commit 6e64944bdbdad7a7d6e4262b390c8134c099fc46 by Matthieu Gallien to branch master.
Loading...