fix no-display of CPU bars per core (and fix some warnings)
Review Request #129838 - Created Jan. 15, 2017 and updated
See bug #373776
The CPU bars do not show a value when using separate bars per CPU, and the tooltip never
shows a value per CPU, since the data sources per CPU are not subscribed.
AFAICT this could never have worked.
seems mostly fine.
I think we want:
otherwise if cores doesn't change we don't add all the other important sources.
Given libksysguard has a tonne of backends, and the main linux one has this guarded in _SC_NPROCESSORS_ONLN this seems it could happen.
this doesn't match anything in the commit description.
The current/old version uses "connectSource(source)" to add the CPUs when they are added in onSourceAdded, but that is not good if the sources are added before SystemLoadViewer.qml (a problem when adding a second SytemLoadViewer) I'm fine with this change, but it seems indeed strange that you first only connect "system/cores" What happens if you use connectSource(...) in onNewData in stead of setting all of connectedSources again?