Bug Fix: When triple click is used to select a line, the final LF should not be included.

Review Request #129786 - Created Jan. 7, 2017 and updated

Information
Aniketh Girish
konsole
master
199381
Reviewers
konsole
dfaure, hindenburg

While triple clicking to select the words, it was actually selecting the line feed too. So this helps with selecting the words without selecting the line feeds.


  

Issues

  • 1
  • 0
  • 0
  • 1
Description From Last Updated
I don't understand this, we want triple clicking to go to the end of the line, albeit without the final ... David Edmundson David Edmundson
Aniketh Girish
Review request changed

People:

+hindenburg
+dfaure
David Edmundson

   
src/TerminalDisplay.cpp (Diff revision 1)
 
 

if you do this then nothing will set _lineSelectionMode to true, so if this is right, it means we can clean up some other code.

  1. So what do you mean to say? Need to keep it in the _lineSelectionMode itself or _wordSelectionMode is better ?

src/TerminalDisplay.cpp (Diff revision 1)
 
 

I don't understand this, we want triple clicking to go to the end of the line, albeit without the final LF.

This is only going to select from the start of the line to the current word.

Loading...