[frameworks] Enable -Wsuggest-override for g++ >= 5.0.0
Review Request #129724 - Created Dec. 29, 2016 and submitted
|Albert Astals Cid|
Gives a nice warning about something that should be marked as override but isn't
Status: Closed (submitted)
Submitted with commit d1d637fadd6dad68995d44101250ebbc3307ed0b by Albert Astals Cid to branch master.
Is that enabled by default now? I hope not! This is a completely useless warning for all frameworks (as we are not allowed to use override) and even more for a legacy code bases. I don't want to have to adjust the cmake in all projects I maintain to silence this warning again. And even less I want to spent days adding overrides to legacy code base.
Note: This got reverted in master for now, since there were too many warnings caused by this change.
We'll reapply it after the KF5 release. Most of the warnings have been fixed by Laurent a few days ago (and I have a few more patches I'll push after the release).