Properly disable create_dir action
Review Request #129712 - Created Dec. 28, 2016 and submitted - Latest diff uploaded
isFolderWritableis set in DolphinView::updateWritableState according to KFileItemListProperties::supportsWriting(). However,
writing=truedoes not imply
makedir=true, in an ioslave's .protocol file. An example is the trash protocol.
So we need to enable the create_dir action only if the protocol is actually able to create folders.
Go to Trash and press F10 with and without patch.
Note that the create_dir action is already disabled by KIO (you can check by showing the menubar and opening File -> Create New menu), yet it was still listening for shortcuts on the Dolphin side.