Avoid opening duplicate Properties dialogs

Review Request #129589 - Created Nov. 29, 2016 and discarded

Information
Mario Bereš
dolphin
372703
Reviewers
dolphin

You could open duplicate Properties dialogs because every time u hit "Properties" button, a new KPropertiesDialog is created. Now it's stored in class variable until it destroys, if you try to open another KPropertiesDialog it will focus back to already opened one.


  

Issues

  • 4
  • 0
  • 0
  • 4
Description From Last Updated
Use 'class' forward declaration instead of include, see lines below. Christoph Feck Christoph Feck
Spelling Christoph Feck Christoph Feck
Use member initialization instead of assignment. Christoph Feck Christoph Feck
Should we also raise when the dialog was already created? Christoph Feck Christoph Feck
Mario Bereš
Mario Bereš
Mario Bereš
Christoph Feck
Christoph Feck
Mario Bereš
Review request changed

Status: Discarded

Change Summary:

If you are still interested in this fix, please upload this patch again at https://phabricator.kde.org

Loading...