[okular] Enable searching for a phrase split by a newline character in a PDF

Review Request #129557 - Created Nov. 25, 2016 and updated

Information
Marduk Bolanos
okular
Reviewers
okular
sander

A blank space in the query is matched against a newline character in the PDF.

Tried a few PDF files. It works.

Issues

  • 2
  • 0
  • 0
  • 2
Description From Last Updated
so from = "Hola\n" to = "Adios " returns true? Albert Astals Cid Albert Astals Cid
Do this from == QStringLiter("\n") && to == QStringLiteral(" ") Anthony Fieroni Anthony Fieroni
Marduk Bolanos
Albert Astals Cid
Marduk Bolanos
Anthony Fieroni
Marduk Bolanos
Albert Astals Cid
Marduk Bolanos
Marduk Bolanos
Albert Astals Cid
Marduk Bolanos
Review request changed
Albert Astals Cid

This regresses in this file

http://www.postgresql.org/files/documentation/pdf/8.4/postgresql-8.4-A4.pdf

Open that file with this patch, search for " in ", i.e "in" with a space before and after

An occurrence will be found on page 2 "appear in all"

Now press "Next"

It will find an occurrence where In is at the beginning of a new line. I don't think that's the expected behaviour (and doesn't happen without your patch)

  1. Marduk, ping?

  2. Sorry for the delay. I have been away from my computer for a while. I hope to get back to this issue soon. It ranks near the top in my ToDo list.

Loading...