possible one line bug in KItemListHeaderWidget::setColumns()

Review Request #129525 - Created Nov. 21, 2016 and discarded

Don Nguyen

The current logic checks to see if a key is NOT in a hash, and removes it if it isn't. I don't know exactly what's going on, but it doesn't make sense to me to remove something when it's not there so I suspect this is a bug. I changed the logic to check if the hash does contain the key.

Don't know what to test, but make test passes.

Don Nguyen
Review request changed

Status: Discarded

Change Summary:

This patch reintroduces the issue fixed by https://commits.kde.org/dolphin/e70c2f8aa472c01433f9416c363c698677c5b45f

Proper fix is in https://commits.kde.org/dolphin/35add56ea4b5eedb1f390f6b7801f0881a89d6cd