Fix scrolling in dock panels

Review Request #129409 - Created Nov. 15, 2016 and submitted

Information
Elvis Angelaccio
dolphin
Applications/16.12
365968
fdde7c5...
Reviewers
dolphin
emmanuelp, sandsmark

The reason why scrolling is smooth in the DolphinView but not in the dock panels is: https://bugs.kde.org/show_bug.cgi?id=365968#c19

This patch changes KItemListContainer::updateScrollOffsetScrollBar() to use a new KItemListView::itemSizeHint() method which adapts to the current icon size in the panels. This ensures the scroll is always smooth in both main and dock panels.

BUG: 365968
FIXED-IN: 16.12.0

Scroll is now smoot both in Places and Folders dock panels. Tested with xf86-input-libinput and xf86-input-evded drivers, and libinput on Wayland.

Issues

  • 1
  • 2
  • 0
  • 3
Description From Last Updated
This will break if m_logicalHeightHintCache is empty. Please check it and maybe assign 0.0 instead Emmanuel Pescosta Emmanuel Pescosta
Elvis Angelaccio
Elvis Angelaccio
Aleix Pol Gonzalez
Emmanuel Pescosta
Elvis Angelaccio
Elvis Angelaccio
Elvis Angelaccio
Elvis Angelaccio
Emmanuel Pescosta
Emmanuel Pescosta
Elvis Angelaccio
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted with commit 90beb4a5e37b887caad1e767046a42dad0af1ab3 by Elvis Angelaccio to branch Applications/16.12.
Loading...