VCS commit message width feedback

Review Request #129324 - Created Nov. 3, 2016 and discarded

Information
René J.V. Bertin
kdevplatform
5.1
Reviewers
kde-mac, kdevelop

Transferred to https://phabricator.kde.org/D5139

This patch proposes changes to the way the VCS commit message editor provides feedback concerning the message width.

KDE insists on a 72 character limit for commit messages, and that is probably a very reasonable standard. In the current implementation there is no easy way to judge how far from that threshold we are. The easiest way to do this is by setting the commit message editor to a width of 72 characters (which for some reason requires taking the width of a string of 74 characters). I think there is room enough for this, but a more complete implementation would probably introduce a resize handle between the 2 main widgets. I haven't yet tried to look into that.

Several approaches have been tried during the course of this RR.

On OS X with 2 different fixed font typefaces (sizes). The deleteLater() change has been in use since about 4.7.1 .

Files


Issues

  • 0
  • 6
  • 1
  • 7
Description From Last Updated
Aleix Pol Gonzalez
René J.V. Bertin
Aleix Pol Gonzalez
René J.V. Bertin
René J.V. Bertin
René J.V. Bertin
Friedrich W. H. Kossebau
René J.V. Bertin
Review request changed

Status: Discarded

Loading...