Background music added

Review Request #129312 - Created Nov. 2, 2016 and discarded

Information
Divyam Madaan
gcompris
Reviewers
gcompris
  1. The background music doesn't play on the same instance when we download the music though it gets registered and also works good if automatic update is enabled.
  2. We unregister the background music (similar to wordset) evertime when we close the main configuration box and register it again. If we don't have any updates (no changes in what is existing), is it required and necessary to do it?

music plays after the welcome message in all cases (when audio effects enabled and when audio effects disabled but audio voices anabled) and seems good.

Issues

  • 2
  • 25
  • 2
  • 29
Description From Last Updated
I don't follow much with the indentation but if we go in the first if, we do nothing after? So ... Johnny Jazeix Johnny Jazeix
You probably don't need both: music and rccBackgroundMusic. Also rccBackgroundMusic can never be == '' anymore. Holger Kaelberer Holger Kaelberer
Divyam Madaan
Divyam Madaan
Johnny Jazeix
Divyam Madaan
Holger Kaelberer
Johnny Jazeix
Holger Kaelberer
Johnny Jazeix
Divyam Madaan
Divyam Madaan
Review request changed

Status: Discarded

Change Summary:

It has been moved to https://cgit.kde.org/gcompris.git/log/?h=backgroundMusic So closing it.

Loading...