Hide the "Show Menu Bar" action if all the menubars are native

Review Request #129261 - Created Oct. 25, 2016 and submitted

Information
Albert Astals Cid
kconfigwidgets
129885
Reviewers
kdeframeworks

Some applications have a "Show Menu Bar" action that is a bit silly on systems where the menubar is part of the shell (for example Unity 7).

This patch attempts to fix it by iterating all the main windows when they are shown and if all the menubars of all mainwindows are native, then hides the show menu bar action (basically erasing it from existence).

It's not the nicest of the codes and probably has some edge cases but works on the general case so i think it's worth the effort.

Tried konsole, kate and dolphin under Unity 7 on Ubuntu 16.10

konsole and kate work fine (i.e. the action is gone from the menus and all is good)

dolphin is not 100% "perfectly behabed" (i.e. the "control" toolbar item is supposed to not be shown when menubars are shown and in this case it's shown) but it's not a regression and imho it's the dolphin code being a bit weird (i can propose a patch for it if this gets accepted)

Issues

  • 1
  • 5
  • 0
  • 6
Description From Last Updated
If an application creates many "show menu bar" actions, e.g. one per window in a many-windows process, then it will ... David Faure David Faure
Aleix Pol Gonzalez
Kai Uwe Broulik
David Faure
Albert Astals Cid
Albert Astals Cid
David Faure
Albert Astals Cid
David Faure
Albert Astals Cid
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted with commit 2ae1ef1066c61f9552eea06248a4fda3dde071d5 by Albert Astals Cid to branch master.
Loading...