Minor improvements to the editor UI
Review Request #129221 - Created Oct. 19, 2016 and submitted
- vertical spacing between all widgets set to 6px (previously only few of them had this spacing)
- checkbox alignment according to HIG
- correct label alignment for some VPN widgets
|This label looks misaligned in screenshot 4. I mean, the distance between BSSID and "Restrict to device" labels is bigger ...||Lamarque Souza|
Well, I cannot see most of the changes now because I do not have time to recompile Plasma NM. If you can add screenshots of the changes would help me a low review the changes.
I think the "When connecting to IPv5-capable networks," is not needed. The "IPv4 configuration succeeds" part implies that this setting has effect only when IPv4 is enabled.
Edit list of domain name servers.
The ", on the other hand" part sounds strange. I think it can be omitted.
This tooltip is not accurate. The wifi network is identified by the ssid and may comprise several access points. This option fixes one of those access points so the wifi card does not jump from one access point to another in the same network.
As far as I know someone can have two or more access points in the same network (same ssid) with the same frequency band (same channel). This setting does not seem band specific to me, so the change "network associated to the specified band" does not seem accurate to me.
Images for comparison:
Revision 2 (+781 -671)
Spacing has a meaning. When you, for instance in image 3, have more space between an upper and a lower group I wonder what the reason is. And image 2 has only 1 or 2px instead of ~6px in the other. I suggest you define one distance and use this values for all controls (no need to stick to the exact values at the HIG https://community.kde.org/KDE_Visual_Design_Group/HIG/Placement since it was a proposal back than and still is). And if there a good reason to have more space you should have a second value.
You correctly right align captions but violate this in the last two images. The alignment HIG is a little bit more elaborated https://community.kde.org/KDE_Visual_Design_Group/HIG/Alignment.
"Hidden network" is still missing text after the checkbox. It's needed at least for a11y. https://community.kde.org/KDE_Visual_Design_Group/HIG/CheckBox ("
Password inputs still use the inline storage option. For consistency, you better move it out of the control like discussed in https://git.reviewboard.kde.org/r/129212/ (personally I never had a problem with the inline solution).
Noticed the colon after captions: While it's perhaps today's standard I think the UX specialists should consider a guideline that colons shouldn't be used for labels.