Fix emitting close when an event has no actions

Review Request #129146 - Created Oct. 11, 2016 and submitted

Information
David Edmundson
knotifications
master
2618e4d...
Reviewers
kdeframeworks

KNotificatitionManager::self() has an early check if a notification has
no actions. If it has no actions it tries to close the notification
early. However it's dereferencing an object that it has not referenced,
sending the ref count to -1, a corrupt state that is not handled
gracefully in KNotification, and we don't ever close the notification.

By referencing and dereferencing we're still calling the cleanup in
KNotification (if applicable) but without sending the ref count negative.

This fixes ksmserver waiting for the logout sound to play; which
currently never emits close, as the default setup has no logout sound.

Autotest that used to fail included

Issues

  • 0
  • 0
  • 1
  • 1
Description From Last Updated
Anthony Fieroni
Aleix Pol Gonzalez
David Edmundson
David Edmundson
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted with commit 07a6d3e2e51ee461ad37bb42edad3518f3b8a3e9 by David Edmundson to branch master.
Loading...