Fix the hanging sftp ioslave
Review Request #129134 - Created Oct. 9, 2016 and updated
Fix the hanging sftp ioslave by always calling either finished() or error() to signal the completion of the command, as stated in the ioslave API description.
Works here. I use it since a couple of days without any problems so far.
Good strategy overall, but it seems to me that some of the patch is incorrect.
should probably be error?
It seems to me that sftpLogin() already calls error() in case of an error (at least in most code paths --- if it ever doesn't do that, then that's where it should be fixed). It's wrong to call finished() after error(), so this (and the many other calls like it in your patch) should be removed, I would think.
Are you sure? close() is not standard SlaveBase API.
should be error(unsupported)