Fix the hanging sftp ioslave

Review Request #129134 - Created Oct. 9, 2016 and updated

Information
Emmanuel Pescosta
kio-extras
master
362988
Reviewers
kde-workspace
anschneider, dfaure
Fix the hanging sftp ioslave by always calling either finished() or error() to signal the completion of the command, as stated in the ioslave API description.
Works here. I use it since a couple of days without any problems so far.

Issues

  • 4
  • 0
  • 0
  • 4
Description From Last Updated
should probably be error? David Faure David Faure
It seems to me that sftpLogin() already calls error() in case of an error (at least in most code paths ... David Faure David Faure
Are you sure? close() is not standard SlaveBase API. David Faure David Faure
should be error(unsupported) David Faure David Faure
David Faure

Good strategy overall, but it seems to me that some of the patch is incorrect.

sftp/kio_sftp.cpp (Diff revision 1)
 
 

should probably be error?

sftp/kio_sftp.cpp (Diff revision 1)
 
 

It seems to me that sftpLogin() already calls error() in case of an error (at least in most code paths --- if it ever doesn't do that, then that's where it should be fixed). It's wrong to call finished() after error(), so this (and the many other calls like it in your patch) should be removed, I would think.

sftp/kio_sftp.cpp (Diff revision 1)
 
 

Are you sure? close() is not standard SlaveBase API.

sftp/kio_sftp.cpp (Diff revision 1)
 
 

should be error(unsupported)

Loading...