Please turn it on in your browser preferences.
for specific sites, we recommend the
Review Request #128941 -
Created Sept. 18, 2016 and submitted
Sept. 19, 2016, 11:46 a.m.
builds and runs fine without the dependency
If Konqueror directly uses these symbols it needs to explicitely link to it, even if libkonq does.
I don't see it though, and wrt linking there is no difference after my patch.
I don't get the review description and its relevance to the patch.
I think the comment is wrong. I can't find any zlib references in konqueror itself. Also note that the linkage is actually commented out.
Right, that's why his patch removes that comment ;-)
replace bogus description
Add ECMMarkAsTest, used by fsview tests
I cleaned up the toplevel CMakeLists.txt meanwhile, but the rest of the change is correct, libkonq is the one using crc32 indeed.
Submitted with commit 8f6fe819ff3fe03e2715877aeaffe0d03442d040 by Andreas Sturmlechner to branch master.