Take upload speed into account for maximum plotter value

Review Request #128832 - Created Sept. 5, 2016 and submitted

Information
Jan Grulich
plasma-nm
368247
Reviewers
networkmanagement, plasma

When the upload speed is higher then the download we should set maximum plotter value based on that.


  

Issues

  • 2
  • 0
  • 0
  • 2
Description From Last Updated
All of this could be simplified to: onValuesChanged: maxValue = Math.max.apply(null, downloadPlotData.values.concat(uploadPlotData.values)) (if values behaves like a JS Array) Also, ... Kai Uwe Broulik Kai Uwe Broulik
Make property readonly and add an empty line afterwards Also perhaps add a comment on how Math.max in conjunction with ... Kai Uwe Broulik Kai Uwe Broulik
Kai Uwe Broulik
Jan Grulich
Jan Grulich
Kai Uwe Broulik
Jan Grulich
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted with commit 8962e3b6837e8a6a047a848763f0ef5b2b91632d by Jan Grulich to branch Plasma/5.7.
Loading...