Oliver Sander got a fish trophy!

[frameworks] Implement zooming with a pinch gesture on a touch screen

Review Request #128821 - Created Sept. 3, 2016 and submitted

Information
Oliver Sander
okular
frameworks
366781
Reviewers
okular

The attached patch implements document zoom controlled by a two-finger pinch gesture on a touch screen.

The actual zooming was done by copy'n'paste, I don't understand the full details of how zooming works in okular, yet. So a bit of review would be appreciated.

I tested it on my Lenovo Thinkpad Yoga, and it works nicely there.

Issues

  • 1
  • 5
  • 0
  • 6
Description From Last Updated
Martin wants early return for code clarification if (!pinch) { return false; } Anthony Fieroni Anthony Fieroni
Martin Tobias Holmedahl Sandsmark
Oliver Sander
Martin Tobias Holmedahl Sandsmark
Anthony Fieroni
Oliver Sander
Martin Tobias Holmedahl Sandsmark
Oliver Sander
Martin Tobias Holmedahl Sandsmark
Oliver Sander
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted with commit 9d90a08ef5e22d682a5a5004128f72d1a5a84aff by Martin T. H. Sandsmark to branch frameworks.
Loading...