Fix crash on exit

Review Request #128760 - Created Aug. 25, 2016 and submitted

Information
Peter Wu
breeze
master
356940
Reviewers
plasma
davidedmundson, dfaure, hpereiradacosta

Since Qt 5.6.0, Qt5 applications started crashing on exit. All signs
point to this delete-on-destroy hack which was added to avoid outliving
the plugin lifetime.

This method is wrong because the returned style is owned by the caller
(QApplication, QProxyStyle, etc) and will cleaned up when those users
are destructed.

Ran the updated test.sh from "Testcase (ASAN) with normal QApplication::quit and exit()" from bug https://bugs.kde.org/show_bug.cgi?id=356940, no longer crashes. Tested with Qt 5.7.0.

Issues

  • 0
  • 0
  • 1
  • 1
Description From Last Updated
Anthony Fieroni
Peter Wu
Hugo Pereira Da Costa
Peter Wu
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted with commit d0cc0029d38f5cf745e32753add8f11609a67c30 by Hugo Pereira Da Costa to branch Plasma/5.8.
Loading...