Improvements to search highlighting in KateSearchBar

Review Request #128592 - Created Aug. 3, 2016 and updated

Information
Roman Gilg
ktexteditor
master
365903
128850
Reviewers
kate
cullmann, dhaumann

This change polishs the highlighting functionality in KTextEditor:

Incremental Search: All found items will be automatically highlighted now.
- This is the default behaviour of most other programs (e.g. Qt Creator, Google Chrome) and also in Kate's 'Search and Replace' plugin.
- The old behaviour can confuse the user, since searching for a whole word highlights all these (but not if the word is part of another one), see the bug.

Power Search: Searching next match or replacing one won't set the highlighting to a wrong region anymore. This was a bug.

FEATURE: 365903

Compiles fine and did some manual tests with different texts and search patterns. Tested in compiled Kate and KDevelop5.

Issues

  • 0
  • 7
  • 0
  • 7
Description From Last Updated
Anthony Fieroni
Roman Gilg
Milian Wolff
Roman Gilg
Anthony Fieroni
Roman Gilg
Milian Wolff
Roman Gilg
Roman Gilg
Anthony Fieroni
Roman Gilg
Review request changed

Change Summary:

Adjust to simplified helper class.

Diff:

Revision 7 (+85 -4)

Show changes

Loading...