Send EOF before sending SIGHUP when closing

Review Request #128416 - Created July 9, 2016 and submitted

Information
Martin Tobias Holmedahl Sandsmark
konsole
185140
Reviewers
konsole
hindenburg, ossi

According to http://permalink.gmane.org/gmane.comp.shells.bash.bugs/12602 (from https://bugs.kde.org/show_bug.cgi?id=185140), sending EOF is the appropriate way of telling e. g. bash to quit.

I wasn't able to get KPtyProcess to send that in a nice way (calling setStandardInputFile(QProcess::nullDevice(), for example), so we fetch the EOF character manually with tcgetattr and send that.

Running backgrounded processes (e. g. launching «kate&») and then closing the tab/window now leaves the backgrounded tasks running, which is apparently The Right Thing.

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
Oswald Buddenhagen
Martin Tobias Holmedahl Sandsmark
Martin Tobias Holmedahl Sandsmark
Kurt Hindenburg
Oswald Buddenhagen
Martin Tobias Holmedahl Sandsmark
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted with commit 2f1c8cf397be6c91fcd60234740d9727650c1a87 by Martin T. H. Sandsmark to branch master.
Loading...