support -iframework and -F header search path options

Review Request #128272 - Created June 21, 2016 and submitted

Information
René J.V. Bertin
kdevelop
Reviewers
kde-mac, kdevelop

This is a draft implementation for parser support of the -iframework dir and -F dir compiler arguments. On OS X these are the framework equivalents of -isystem and -I respectively, telling the compiler and/or linker where to find framework bundles.

I started out making the new code available on OS X only but that introduces a lot of #ifdefs for probably little benefit. On the contrary, clang supports the arguments on Linux too, presumably because clang is a functional cross-compiler that can generate Darwin Mach-O object files on Linux too.

For the 1st approach I propose to parse the framework directories, adding the effective header directories of the individual frameworks as if they were added explicitly. The framework directories are also added to a new list in the result structure. I presume that this is a prerequisite for adding them to the (lib)clang arguments of the clang parser.

the unittest works as expected on OS X.

20160625: the patch works as expected on OS X. The -iframework /opt/local/libexec/qt5/Library/Frameworks argument added by cmake to each compiler invocation is detected and put to use; Qt header files are found in the frameworks without a wrapper Qt5 header directory (/opt/local/include/qt5) added to the header search path. Header files from the system SDKs are found too

Files


Issues

  • 0
  • 29
  • 6
  • 35
Description From Last Updated
René J.V. Bertin
Milian Wolff
René J.V. Bertin
Milian Wolff
René J.V. Bertin
René J.V. Bertin
René J.V. Bertin
Milian Wolff
Milian Wolff
René J.V. Bertin
Milian Wolff
Milian Wolff
René J.V. Bertin
Review request changed

Status: Closed (submitted)

Change Summary:

This is the 3rd RR in a row that isn't closed by added the usual "REVIEW: X" line

https://quickgit.kde.org/?p=kdevelop.git&a=commit&h=46c0ea43dd3f51cb45e000b528f36bbc83802fac

Loading...