Don't trust files claiming to be created on unix more than other files

Review Request #128233 - Created June 17, 2016 and submitted

Information
Sune Vuorela
karchive
Reviewers
kdeframeworks
dfaure

Don't trust files claiming to be created on unix more than other files

For some historical reasons, we special case zip files claiming to be
created on unix and trust the content regarding file rights a bit better.

Zip files in the wild have shown to violate this, so don't trust them.

Thanks to Jonathan Marten for the test case

BUG: 364071

  

Issues

  • 5
  • 0
  • 0
  • 5
Description From Last Updated
That's not really a unit test, if the person running the test has to read the output ;) David Faure David Faure
This loses permission information (e.g. 0755 vs 0750 vs 0700). How about just access |= S_IFDIR, i.e. ensuring it's a ... David Faure David Faure
s/data/fileName/ David Faure David Faure
QString() David Faure David Faure
join(' ') The fromUtf8() looks a bit overkill, it's all ascii ;) David Faure David Faure
David Faure
Sune Vuorela
David Faure
Sune Vuorela
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted with commit b7d8fce0a7167f4cea7127c6142ea10c92ff546d by Sune Vuorela to branch master.
Loading...