[libtaskmanager] Stop highlighted window effect in group item

Review Request #128038 - Created May 28, 2016 and submitted

Information
Anthony Fieroni
plasma-desktop
Plasma/5.8
Reviewers
plasma
broulik, davidedmundson, hein
  1. Enable highlighted window, tooltips and grouping
  2. Open group item tasl by clicking left mouse button
  3. Move mouse cursor over item in group

Before:
1. Items are samll and tough readable
2. Items aren't visible cause a highligthWindow effect
3. Clicking on tooltip close button case highlightWindow effect to not stop

After:
1. Items are proof readable
2. Items are visible
3. HighlightWdindow effect is stopped

Screenshot with expected behavior by clicking left button on group item.

Files


Issues

  • 1
  • 0
  • 0
  • 1
Description From Last Updated
note we've moved to phabricator for review requests, which is why this got ignored. Though this was still unexcusable on ... David Edmundson David Edmundson
Eike Hein
Anthony Fieroni
Anthony Fieroni
Anthony Fieroni
Anthony Fieroni
Anthony Fieroni
Anthony Fieroni
Anthony Fieroni
Anthony Fieroni
Anthony Fieroni
Anthony Fieroni
Anthony Fieroni
Anthony Fieroni
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted with commit aeec4ae8869b487fe516a920b49a1fde4ea48c06 by Anthony Fieroni to branch Plasma/5.8.
David Edmundson

   

note we've moved to phabricator for review requests, which is why this got ignored.
Though this was still unexcusable on our side for not commenting in 6 months.

Why are you multiplying anything by devicePixelRatio in this ?
The logic is saying "don't be more than a 3rd of the screen width".

Also, to match the comment in the TODO this should be Screen.desktopAvailableWidth

  1. About me, 640 is exactly 1920/3 in TODO. If you think this should be
    property int preferredWidth: Screen.desktopAvailableWidth / (3 * Screen.devicePixelRatio)
    property int preferredHeight: Screen.desktopAvailableHeight / (2 * Screen.devicePixelRatio)
    i will committed.

Loading...