kdesrc-build: improve error messages by showing the right filename
Review Request #127910 - Created May 13, 2016 and submitted
Before: "Don't use module libaccounts-qt on line 20 of /path/kdesrc-buildrc, use options libaccounts-qt" but line 20 is unrelated, some global option. After: "Don't use module libaccounts-qt on line 20 of /path/extragear/utils/kdesrc-build/kf5-workspace-build-include, use options libaccounts-qt"
|`$result` here is the old filehandle (so it can be closed) so this boolean won't work. If you wanted to ...||Michael Pyne|
I'd like an added comment to keep me honest later but looks very good otherwise, thanks for the fix!
Review request changed
Looks good aside from one remaining issue!
`$result` here is the old filehandle (so it can be closed) so this boolean won't work. If you wanted to be fancy you could use comma operator perhaps, but it's probably best to just put the filename stack update on a separate line. Alternately we could close the fh here and free up the calling code from doing it, and then return nothing... might be clearer that way.