Revert "Don't import an nonexistent layout"

Reviews
Diff

- Download Diff

Information
Submitter:	David Rosca
Repository:	plasma-framework
Branch:	master
Bugs:	360777
Depends On:
Reviewers
Groups:	plasma
People:	apol

Description

importLayout is not called when started from SDDM which results in startupCompleted not being emitted and splash waiting for timeout.

This reverts commit 309c64f5e90453c5253baf19e6c01759e8aa6f83.

Testing Done

No more splash timeouts.
For plasmashell tests, the startupCompleted is emitted 2 times, so tests run 4 times too (twice for each startupCompleted signal..).

Testing Done:

		No more splash timeouts.
~		For plasmashell tests, the startupCompleted is emitted 4 times, so tests run 4 times too. Without this patch, startupCompleted is emitted twice, so it needs fixing in plasmashell.
	~	For plasmashell tests, the startupCompleted is emitted 2 times, so tests run 4 times too (twice for each startupCompleted signal..).

+1
Even the progressbar steps backward

I understand it's a bit complex, but it's also not really acceptable that the signal is emitted twice. Let me try to come up with an alternative.

David Rosca May 6, 2016, 3:45 p.m.

Sure, no problem. When running plasmashell from terminal without any arguments, the startup completed is emitted once. Only with plasmashell --test it is emitted twice.

Aleix Pol Gonzalez May 6, 2016, 3:46 p.m.

It's emitted twice because the first time it loads an empty corona configuration file, then it finishes and shellcorona realizes there's no containments and decides to load the default on its own.

Aleix Pol Gonzalez May 6, 2016, 3:57 p.m.

See https://git.reviewboard.kde.org/r/127850/

You have a pending review.

Review Board 2.5.15

Screenshots

Files

Testing Done:

Status: Discarded