Q_BYTE_ORDER not defined in the kwallet backends
Review Request #127806 - Created May 1, 2016 and submitted
the kwalletd backends (blowfish and sha1) rely on Q_BYTE_ORDER being defined. Since it looks like we want to keep sha1.cc and blowfish.cc "Qt-clean" I put the include for QtCore/qglobal.h into the config-kwalletbackend.h.
compiles. now Q_BYTE_ORDER is defined by qglobal.h
You say: since it looks like we want to keep sha1.cc and blowfish.cc "Qt-clean"
Clearly that is not the case, if they use Q_BYTE_ORDER. So if it's OK for them to use Q_BYTE_ORDER, it's ok for them to include qglobal.h.
I don't see any reason to do so in the cmake-generated header file.